Skip to content
Snippets Groups Projects

Draft: [Fix] Read velocity from field in UBB

Open Markus Holzer requested to merge holzer/lbmpy:UBBVelocity into master
All threads resolved!

In the UBB boundary condition, the velocity is taken from neighbouring points when a field is provided. However, this also results in prescribing a different velocity for PDFs of the same cell which can not be intentional. With this MR the velocity is taken from the source cell instead

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Philipp Suffa resolved all threads

    resolved all threads

  • Philipp Suffa approved this merge request

    approved this merge request

  • Markus Holzer marked this merge request as draft

    marked this merge request as draft

  • cupy in pipeline was fixed with !185 (merged), so you can merge from master to finish this one and !184

  • Please register or sign in to reply
    Loading