Skip to content
Snippets Groups Projects

Extend testsuit

Merged Markus Holzer requested to merge holzer/pystencils:Extend_testsuit into master
All threads resolved!

This MR extends the test cases of pystencils.

Other changes made in this MR:

  1. Usage of correct backends for the codegen instead of C Backend for all
  2. Deletion of unusable function.
  3. Correction of CUDA and OpenCL Array handler

Merge request reports

Pipeline #27125 passed

Pipeline passed for fb2437d4 on holzer:Extend_testsuit

Merged by Stephan SeitzStephan Seitz 4 years ago (Oct 13, 2020 11:16am UTC)

Loading

Pipeline #27274 passed

Pipeline passed for d1f332bd on master

Test coverage 86.02% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 11 commits

    added 11 commits

    • 8836e8bc...43bdbcb8 - 10 commits from branch pycodegen:master
    • 75d1bce8 - Merge remote-tracking branch 'upstream/master' into Extend_testsuit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    • 73f658b2 - Removed interpolation specific function

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    • 20a4cf3a - Removed toml writer and added test cases to json backend

    Compare with previous version

  • Das Json/toml Zeug kann doch auch weg. Ich habe auch einen debug printer der hinter allen was er printed den Typ hinschreibt (als Kommentar).

    Edited by Stephan Seitz
  • Der toml writer hat gar nicht funktioniert, weil es eine circular dependency gab. Das lag daran, wie das dict aufgebaut ist, das er printen soll. Ich denke das wäre eher aufwändig/unnötig gewesen das zu fixen.

    Würde der debug printer dann einfach Json und Yaml erstzen?

  • Ich weiß nicht, ob das in pystencils gehört. Hast du jemals das json gebraucht? Es war ab und zu zum debuggen ganz nett aber wirklich brauchen tut mans nicht.

    Der debug printer ist in pystencils_autodiff. FrameworkIntegrationPrinter könnte man auch durch CBackend ersetzen. Denke das ist besser, wenn jeder das einfach selber in seinem code hat. Dann kann man in die Kommentare seine eigenen Infos schreiben, die man braucht. Die Implementierung ist auch destruktiv. D.h. einmal den debug printer benutzen heißt, dass man den immer bis zum Python Neustart hat.

    class DebugFrameworkPrinter(FrameworkIntegrationPrinter):
        """
        Printer with information on nodes inlined in code as comments.
    
        Should not be used in production, will modify your SymPy printer, destroy your whole life!
        """
    
        def __init__(self):
            super().__init__()
            self.sympy_printer._old_print = self.sympy_printer._print
            self.sympy_printer.__class__._print = self._print
    
        def _print(self, node):
            if isinstance(node, sp.Expr):
                return self.sympy_printer._old_print(node) + f'/* {node.__class__.__name__}: free_symbols: {node.free_symbols} */'  # noqa
            elif isinstance(node, pystencils.astnodes.Node):
                return super()._print(node) + f'/* {node.__class__.__name__} symbols_undefined: {node.undefined_symbols}, symbols_defined: {node.symbols_defined}, args {[a if isinstance(a,str) else a.__class__.__name__ for a in node.args]} */'  # noqa
            else:
                return super()._print(node)
    Edited by Stephan Seitz
  • Markus Holzer added 2 commits

    added 2 commits

    • 3d95acec - Removed log_progress from jupyter extension due to deprication
    • cc75f76d - Added test for jupyter extensions

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    • fb2437d4 - Added test case for pow printing to llvm

    Compare with previous version

  • Michael Kuron resolved all threads

    resolved all threads

  • Michael Kuron approved this merge request

    approved this merge request

  • Michael Kuron assigned to @seitz and unassigned @kuron

    assigned to @seitz and unassigned @kuron

  • merged

  • Stephan Seitz mentioned in commit d1f332bd

    mentioned in commit d1f332bd

  • Please register or sign in to reply
    Loading