Add own implementation for printing an unknown function (!96) · Merge requests · pycodegen / pystencils · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Add own implementation for printing an unknown function

seitz/pystencils:function-call-printing into master

Merged Stephan Seitz requested to merge seitz/pystencils:function-call-printing into master 5 years ago

Using the SymPy implementation for printing a sympy.Function has some issues:

you cannot use cast_func as an argument -> SymPy prints `cast_func(2,float)
typed numbers are not typed any more -> e.g. pow(x, 0.25) instead of pow(x, 0.25f)

Maybe a disadvantage or an advantage:

arbitrary Functions: sympy.Function('my_function') are now allowed.

Would have prevented commits like:

Fix: type of sqrt(int) was int not floating point type

Edited 5 years ago by Stephan Seitz

Activity

Stephan Seitz added 17 commits 5 years ago
added 17 commits

ff99cee9...c4e92d45 - 15 commits from branch pycodegen:master

a1c374cc - Add own implementation for printing an unknown function

5e7d3c9c - Update tests for new function-call-printing

Compare with previous version
Stephan Seitz changed the description 5 years ago

changed the description
Martin Bauer merged 5 years ago

merged
Martin Bauer mentioned in commit 2f4313fd 5 years ago

mentioned in commit 2f4313fd
Stephan Seitz mentioned in merge request !100 (closed) 5 years ago

mentioned in merge request !100 (closed)

Please register or sign in to reply