Skip to content
Snippets Groups Projects

Refactor DEFAULTS & fix bugs concerning data types of spatial counter symbols

Merged Frederik Hennig requested to merge da15siwa/pystencils:fhennig/dtype-bugs into v2.0-dev
  • Remove genericity from pystencils.DEFAULTS, use TypedSymbols only
  • Use DynamicType.INDEX_TYPE in counter symbols
  • Fix a bug where the SparseIterationSpace declared the spatial counters const, leading to a type conflict with the non-const counters in DEFAULTS
  • Add test cases for usage of spatial counters in dense and sparse kernels
  • On the side: Add py.typed to facilitate type checking in downstream projects (why was this missed for so long?)

Merge request reports

Pipeline #70180 passed

Pipeline passed for b8024740 on da15siwa:fhennig/dtype-bugs

Test coverage 84.96% (0.00%) from 1 job

Merged by Frederik HennigFrederik Hennig 6 months ago (Nov 12, 2024 7:39am UTC)

Loading

Pipeline #70221 passed

Pipeline passed for 722fa3ce on v2.0-dev

Test coverage 84.96% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply