Skip to content
Snippets Groups Projects

Allow index expression for indexed domain kernel

Merged Allow index expression for indexed domain kernel
holzer/pystencils:ExtendIndexedDomainKernel into master
2 unresolved threads
Merged Markus Holzer requested to merge holzer/pystencils:ExtendIndexedDomainKernel into master
2 unresolved threads

When creating an indexed domain kernel, using a single TypedSymbold is the only possibility. This MR the previous restriction and allows to use an expression that is depended on a single symbol

Merge request reports

Merge request pipeline #69213 passed

Stage: pretest
Stage: test
Stage: docs

Merge request pipeline passed for 4076bda2

Test coverage 87.08% from 1 job
Approved by
Michael Kuron
Test summary results are being parsed
Full report

Merged by Michael KuronMichael Kuron 8 months ago (Sep 28, 2024 10:23am UTC)

Merge details

  • Changes merged into master with a7d1b278 (commits were squashed).
  • Deleted the source branch.

Pipeline #69292 passed

Stage: pretest
Stage: test
Stage: docs
Stage: deploy

Pipeline passed for a7d1b278 on master

Test coverage 87.04% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/pystencils/gpu/kernelcreation.py
72 72
73 73 if len(indexed_elements) > 0:
74 74 common_indexed_element = get_common_indexed_element(indexed_elements)
75 index = list(common_indexed_element.indices[0].atoms(TypedSymbol))
  • Michael Kuron
    Michael Kuron @kuron started a thread on an old version of the diff
    • src/pystencils/transformations.py
    276 276 if len(indexed_elements) == 0:
    277 277 return loop_node
    278 278 reference_element = get_common_indexed_element(indexed_elements)
    279 index = list(reference_element.indices[0].atoms(TypedSymbol))
  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Kuron approved this merge request

    approved this merge request

  • Michael Kuron merged

    merged

  • Michael Kuron mentioned in commit a7d1b278

    mentioned in commit a7d1b278

    • Please register or sign in to reply