Skip to content
Snippets Groups Projects

Some minor internal and API fixes

Merged Frederik Hennig requested to merge fhennig/quickpatch into v2.0-dev
3 unresolved threads
  • Fix wrong legacy imports in alignedarray, simplificationfactory and runhelper.db
  • Fix doctests that got broken with numpy 2.0
  • Disable graphviz for ASTs (not yet implemented)
  • Fix GPU periodicity function usage in data handling
  • Expose KernelConstraintsError at top-level

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 17 18 align_inner_coordinate: if True, the start of the innermost coordinate lines are aligned as well
    18 19 """
    19 20 if byte_alignment is True or byte_alignment == 'cacheline':
    20 from pystencils.backends.simd_instruction_sets import (get_supported_instruction_sets, get_cacheline_size,
    21 get_vector_instruction_set)
    21 # from pystencils.backends.simd_instruction_sets import (get_supported_instruction_sets, get_cacheline_size,
    22 # get_vector_instruction_set)
    22 23
    23 instruction_sets = get_supported_instruction_sets()
    24 # instruction_sets = get_supported_instruction_sets()
    25 # TODO fix this
  • 18 17
    19 18 graph_style = {} if graph_style is None else graph_style
    20 19
    21 if isinstance(expr, Node):
    22 from pystencils.backends.dot import print_dot
    23 return graphviz.Source(print_dot(expr, short=short, graph_attr=graph_style))
    24 else:
    20 # if isinstance(expr, Node):
    21 # from pystencils.backends.dot import print_dot
    22 # return graphviz.Source(print_dot(expr, short=short, graph_attr=graph_style))
    23 if isinstance(expr, sp.Basic):
    25 24 from sympy.printing.dot import dotprint
    26 25 return graphviz.Source(dotprint(expr, graph_attr=graph_style))
    26 else:
    27 # TODO nbackend
  • You can directly merge it yourself once the two lines of comments are added.

  • Michael Zikeli approved this merge request

    approved this merge request

  • added 1 commit

    • 4df3e544 - Remove unneccesary doctest code; add more descriptive TODO comments

    Compare with previous version

  • Frederik Hennig enabled an automatic merge when the pipeline for 4df3e544 succeeds

    enabled an automatic merge when the pipeline for 4df3e544 succeeds

  • mentioned in commit bbeba6db

  • Please register or sign in to reply
    Loading