Skip to content
Snippets Groups Projects

[Fix] Vectorisation of Abs

Merged Markus Holzer requested to merge holzer/pystencils:VectorAbs into master
All threads resolved!

When an abs function is encountered the Vector printer checks if its argument is a 'VectorMemoryAccess'. This causes two issues 1. only abs functions containing a field access can be vectorised and 2. even worse, if the abs function does not contain a 'VectorMemoryAccess' the scalar version is printed which causes faulty code.

This MR simply removes the condition.

Merge request reports

Approved by
Test summary results are being parsed

Merged by Michael KuronMichael Kuron 8 months ago (Sep 28, 2024 10:20am UTC)

Merge details

  • Changes merged into master with d8586152 (commits were squashed).
  • Deleted the source branch.

Pipeline #69291 failed

Pipeline failed for d8586152 on master

Test coverage 87.07% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Kuron
  • added 1 commit

    Compare with previous version

  • Looks good, but four out of the six tests are failing. Only field-sse-float64 and scalar-float64 succeed, while all avx and all float32 fail.

  • Michael Kuron resolved all threads

    resolved all threads

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Kuron
  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Kuron resolved all threads

    resolved all threads

  • Michael Kuron approved this merge request

    approved this merge request

  • Michael Kuron mentioned in commit d8586152

    mentioned in commit d8586152

  • Please register or sign in to reply
    Loading