Skip to content
Snippets Groups Projects

Implement sp.Sum, sp.Product

Merged Implement sp.Sum, sp.Product
seitz/pystencils:sum-prod into master
Merged Stephan Seitz requested to merge seitz/pystencils:sum-prod into master

Sum and Product have a indexing variable which is a Atom but not a free symbol. So logic, that defines the undefined symbols in a SympyAssignment should not be atoms(sp.Symbol) but free_symbols. sp.Indexed from the ResolvedFieldAcesses forms an edge case. So we could also use atoms(sp.Symbol).intersection(...free_symbols).

I hope I extracted from my fork all the necessary code to implement this feature.

Edited by Stephan Seitz

Merge request reports

Pipeline #17378 passed

Stage:

    Pipeline passed for 5944a759 on seitz:sum-prod

    Merged by Martin BauerMartin Bauer 5 years ago (Aug 21, 2019 4:45pm UTC)

    Loading

    Pipeline #17421 passed

    Stage:
      Stage:

        Pipeline passed for e3d8f12b on master

        Test coverage 78.96% from 0 jobs

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        Please register or sign in to reply