Skip to content
Snippets Groups Projects

[FIX] Alignement detection

Merged Markus Holzer requested to merge holzer/pystencils:FixAlign into master
1 unresolved thread

For the SIMD vectorization it needs to be determined if a memory address lies points to an aligned address or not. This detection only worked for pointers depending on the inner loop counter so far.

Merge request reports

Pipeline #55813 passed

Pipeline passed for 95564cf6 on holzer:FixAlign

Test coverage 86.64% (-0.12%) from 1 job
Approved by

Merged by Michael KuronMichael Kuron 1 year ago (Sep 18, 2023 8:28pm UTC)

Merge details

  • Changes merged into master with bb7a3cf2 (commits were squashed).
  • Deleted the source branch.

Pipeline #55843 passed

Pipeline passed for bb7a3cf2 on master

Test coverage 86.79% (-0.12%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Kuron
  • Michael Kuron
  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Kuron resolved all threads

    resolved all threads

  • Michael Kuron approved this merge request

    approved this merge request

    • test_alignment_and_correct_ghost_layers fails on SVE and RVV. Please fix. I assume this happens because we no longer generate the alignment check on these ISAs because they don't have separate aligned and unaligned load/store instructions. In this case, bypass the with pytest.raises(ValueError) if ast.instruction_set['loadA'] == ast.instruction_set['loadU'].

    • I saw that there are cases where loadA and loadU are similar and still the alignment check was performed (e.g. Neon instruction set). This is due to a fixed vector width. I now removed the alignment check for these architectures. Is this ok from your perspective?

    • Please register or sign in to reply
  • Markus Holzer added 1 commit

    added 1 commit

    • 18007275 - Fix if loada and loadu are similar

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Michael Kuron mentioned in commit bb7a3cf2

    mentioned in commit bb7a3cf2

  • Michael Kuron mentioned in merge request !354 (merged)

    mentioned in merge request !354 (merged)

  • Please register or sign in to reply
    Loading