[Fix] GPU Buffer with iteration slices
1 unresolved thread
1 unresolved thread
GPU buffers did not work in combination with iteration slices before. This is resolved here
Merge request reports
Activity
added Bug label
requested review from @ob28imeq
assigned to @holzer
added 5 commits
-
ecbc924d...0cac3c27 - 4 commits from branch
pycodegen:master - 393854c1 - Fix merge conflict
-
ecbc924d...0cac3c27 - 4 commits from branch
44 44 field_accesses = {e for e in field_accesses if not e.is_absolute_access} 45 45 num_buffer_accesses += sum(1 for access in eq.atoms(Field.Access) if FieldType.is_buffer(access.field)) 46 46 47 # common shape and field to from the iteration space 47 48 common_shape = get_common_shape(fields_without_buffers) 49 common_field = list(sorted(fields_without_buffers, key=lambda e: str(e)))[0] I think this line is really hard to understand. And for someone new this will be very hard to follow. I am wondering also if it is sure that
fields_without_buffersis always non empty. Otherwise some useful error message might be helpful. So I suggest to move this in a extra functionget_common_fieldand add some docstring to itchanged this line in version 4 of the diff
mentioned in commit 0274362a
Please register or sign in to reply