Skip to content
Snippets Groups Projects

Use closest normal for boundary index list with single_link

Merged Markus Holzer requested to merge holzer/pystencils:CreateIndexList into master
All threads resolved!

For creating the index list just the first stencil entry was taken which is a neighbour of the investigated cell if single_link=True. With this MR the discrete normal is calculated and the neighbouring cell in the normal direction is taken to build up the index array.

Furthermore, the computational cost of the python versions for create_boundary_index_list is reduced drastically because the iteration space is now restricted to the boundary cells and not the entire domain anymore.

Edited by Michael Kuron

Merge request reports

Pipeline #32744 passed

Pipeline passed for 14677e7d on holzer:CreateIndexList

Approval is optional

Merged by Michael KuronMichael Kuron 3 years ago (Jun 18, 2021 10:07am UTC)

Merge details

  • Changes merged into master with cb9cccfb (commits were squashed).
  • Deleted the source branch.

Pipeline #32752 passed

Pipeline passed for cb9cccfb on master

Test coverage 87.66% from 0 jobs

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michael Kuron
  • Michael Kuron
  • Michael Kuron
  • Michael Kuron
  • Markus Holzer changed the description

    changed the description

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer marked this merge request as ready

    marked this merge request as ready

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Markus Holzer added 1 commit

    added 1 commit

    Compare with previous version

  • Michael Kuron resolved all threads

    resolved all threads

  • Michael Kuron changed title from Correction of indexList creation to Use closest normal for boundary index list with single_link

    changed title from Correction of indexList creation to Use closest normal for boundary index list with single_link

  • merged

  • Michael Kuron mentioned in commit cb9cccfb

    mentioned in commit cb9cccfb

  • Please register or sign in to reply
    Loading