Fix deprecation warning for Sympy 1.7

We have to try from newest to oldest import to avoid deprecation warnings.

They added the old import again, but with a deprecation warning.

assigned to @holzer

There is still an error in the pipeline but I think this has nothing to do with your MR. Also could you please run the integration pipeline. Then I can accept the MR.

approved this merge request

@holzer please do not merge! The change from C99 to C11 might actually break code!

Let's try C99?

added 1 commit

• ee9e01f7 - Use C99 also on sympy 1.7

Compare with previous version

marked this merge request as draft

Seems to be fixed with C99 if it was related.

marked this merge request as ready

I think then this MR is ready to merge. But is it really necessary to provide the support for sympy < 1.1? From my side, we could also remove it.

added 1 commit

• fde0a63b - Use C99 also on sympy 1.7

Compare with previous version

Removed sympy < 1.1 (Probably it will not work anymore anyway)

There is also code in assignment.py for pre-1.1

Yes, this is what I am thinking. We make too many changes which we do not test on very old sympy versions. Thus keeping the compatibility in some party of pystencils will not work. Additionally I don't think that this it is really neccessary to keep the compatibility with very old sympy versions.

Now conda and sympy-master are failing again? Re-triggered both. Failure seems to be in vectorization-test

Flaky tests?

added 1 commit

• f212c921 - Remove own Assignment implementation for old SymPy versions

Compare with previous version

We used to have the ubuntu job in CI to test with old sympy versions (1.1). But then @holzer upgraded it to Ubuntu 20.04 (https://i10git.cs.fau.de/pycodegen/pycodegen/-/commit/fa8f958f61bc29520fa2a0d8b729dc48252ff4bd), which we should have probably not done until #21 (closed).

That's a good point. I totally forgot that Ubuntu 18.04 uses sympy 1.1 by default. I will downgrade the ubuntu image again to keep the support until April.

added 1 commit

• f86951c9 - Fix test for old Ubuntu

Compare with previous version

added 1 commit

• db77597b - Fix __getnewargs__

Compare with previous version

added 1 commit

• b7a7a3f0 - Fix __getnewargs__

Compare with previous version

added 1 commit

• c2eebd8e - Skipp broken tests for old sympy versions

Compare with previous version