Skip to content
Snippets Groups Projects

Delete generated file createindexlistcython.c

Merged Stephan Seitz requested to merge seitz/pystencils:python3.9 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    This didn't build anymore with Python 3.9. So I regenerated the file with a more recent version of Cython.

  • This file is gigantic and the problem can resurface after any Python update. Why don't we dynamically call cython to generate it from the .pyx file? We already print a warning "Boundary setup may take very long! Consider installing cython to speed it up" if the compiled module is missing and pyximport fails, so this would not be a hard dependency. Apparently setup.py calls cythonize if available, so you probably only ran into this problem because cython wasn't installed on your computer?

  • Author Maintainer

    The current setup works even if Cython is not installed. It just compiles the C file. The generation is right now only triggered when setup is called with --use-cython. The actual python file is apparently never used.

    The problem was that apparently some deprecated symbols of the C API disappeared. When you're using the C API of Python it may change in any version but it is a least somewhat stable.

    Edited by Stephan Seitz
  • Author Maintainer

    We could change the installation to only generate the cython code if available. I'll push the code. But since pystencils is rather in a frozen "only fix bugs" mode we could also just keep the C file.

  • I'd prefer not to ship files that can be regenerated. And if someone really does not have cython installed, they'll still be able to use boundaries and will get a warning that tells them to install cython.

  • Stephan Seitz added 16 commits

    added 16 commits

    Compare with previous version

  • Stephan Seitz changed title from Regenerate createindexlistcython.c to Delete generated file createindexlistcython.c

    changed title from Regenerate createindexlistcython.c to Delete generated file createindexlistcython.c

  • Stephan Seitz added 1 commit

    added 1 commit

    • 298afc1b - Remove generated file createindexlistcython.c

    Compare with previous version

  • I think this MR is ready to merge?

  • Michael Kuron approved this merge request

    approved this merge request

  • Author Maintainer

    I think so too

  • merged

  • Markus Holzer mentioned in commit f3e81539

    mentioned in commit f3e81539

Please register or sign in to reply
Loading