Fix package requires

The phasefield model requires the generation of a module by Cython. However, this file was not shipped with pypi and cython is not required by lbmpy.

added Bug label

added 1 commit

• 501255d1 - ship generated c file with pypi

Compare with previous version

added 1 commit

• c17cfce4 - Acitvate mrt for quicktests again

Compare with previous version

added 1 commit

• b490231e - Ship generated c file and build it

Compare with previous version

If you include the C file, then Cython should no longer by a requirement since you can also build and inlcude the C file/python module directly. If you include Cython, then the C file should not be necessary.

EDIT: ok, Cython is only a build requirement... as it was before with Martins solution.

Including the generated .c file in the Git repo is not a good idea because it's so big. Can't you just make Cython a build dependency so it generates the .c file before uploading to pypi?

I rather don't want to have Cython a build dependency of lbmpy because it is only used in a very specific part which is hardly used by anyone.

You could have Cython just as a runtime dependency for that feature (it would just generate that file at the user side). We already have features like gpu, opencl, interactive...

added 1 commit

• 0e338150 - Remove generated file

Compare with previous version

Now I have removed it from git. If I build the pypi package the generated C-File will be shipped with the package.

added 1 commit

• 9e03f794 - Cython required for phasefield

Compare with previous version

added 1 commit

• e36c40c7 - Fix import try

Compare with previous version

added 1 commit

• e583b315 - Clean up

Compare with previous version

approved this merge request

merged

mentioned in commit 3f3c98cd