Fix: momentum density calculation

Fixes the momentum density calculation for compressible methods with force model. Before the macroscopic velocity shift was used, now we introduce the macroscopic momentum density shift to avoid dividing by the density twice in the force correction step.

Solves issue #14 (closed).

Could you please provide a test case that checks for all force models whether all this shifting is consistent and physically correct?

Could you please make the source branch readable for me. This PR might solve my current problem. Thanks

I think you already should have access to this branch since it is not contained in a fork but in the pycodegen repo.

The branch is called mr_bugfix_momentum_density_calculation.

Markus, the branch only became visible after someone made me "developer" yesterday. BTW: It solves the issue in walberla/walberla!355 (merged).

Yes, I gave you a developer status yesterday. Good to know that this is necessary to see the other branches. I actually gave you the status just because I have seen that you were still only a reporter which didn't make much sense to me.

I wonder what's the purpose of guest. Apparently, you can do nothing with it. Maybe commenting on public repo?

@schottenhamml, could you please provide tests? @RudolfWeeber just told me that this merge request is precisely what he needs, so I would like to see it merged soon.

assigned to @schottenhamml and unassigned @holzer

Yep, sorry for the delay! I've been quite busy lately. But it is still on my Todo list and I will try to write the tests as soon as my work allows.

Any news here? This one is rather important for the Espresso-Walberla-coupling

assigned to @holzer and unassigned @schottenhamml

added 54 commits

• 46a4f761...7df9ca58 - 53 commits from branch master
• 85c96fd1 - Merge branch 'master' of i10git.cs.fau.de:pycodegen/lbmpy into...

Compare with previous version

added 1 commit

• e8bf1fd5 - Added test case to check momentum density

Compare with previous version

The test case should work. It just simply checks the shift, if the PDFs are initialized by zero because then only the shift is what's left.

added 1 commit

• 6671ab51 - use force model keyword

Compare with previous version

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 6671ab51 succeeds

merged

mentioned in commit 2525e615