[FIX] PSM generation (!180) · Merge requests · pycodegen / lbmpy · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Merged [FIX] PSM generation

holzer/lbmpy:fixPSM into master

Merged Markus Holzer requested to merge holzer/lbmpy:fixPSM into master 6 months ago

Due to !176 (merged) an assertion was introduced in the creation of the symbolic relaxation matrix. The assertion tests that all entries of the symbolic relaxation matrix are sympy symbols. However, when a relaxation_rates_modifier this might not be the case.

This MR fixes the problem and introduces a test case with the psm method

Activity

Markus Holzer added Bug label 6 months ago

added Bug label
Markus Holzer requested review from @ed94aqyc 6 months ago

requested review from @ed94aqyc
Markus Holzer assigned to @holzer 6 months ago

assigned to @holzer
Philipp Suffa added 1 commit 5 months ago
added 1 commit

a03e2b72 - Extended tests for PSM

Compare with previous version
Philipp Suffa requested review from @holzer and removed review request for @ed94aqyc 5 months ago

requested review from @holzer and removed review request for @ed94aqyc
Philipp Suffa assigned to @ed94aqyc and unassigned @holzer 5 months ago

assigned to @ed94aqyc and unassigned @holzer
Markus Holzer approved this merge request 5 months ago

approved this merge request
Markus Holzer merged 5 months ago

merged
Markus Holzer mentioned in commit 5ff03a69 5 months ago

mentioned in commit 5ff03a69

Please register or sign in to reply