Introduce NewTypes for Trial- and TestSpace
All threads resolved!
All threads resolved!
Closes #14 (closed).
Introduces NewTypes for Trial- and TestSpace such that mypy can check they are not confused.
- Had to change FunctionSpace from Protocol to ABC.
Comparisons between test and trial spaces now trigger mypy warnings because we are comparing objects of different types. These warnings must be ignored which is a bit nasty but I think worth overall.- Fixed typing of tests.
- This exercise revealed a few mix-ups of trial/test in the tests (mypy told me).
Edited by Daniel Bauer
Merge request reports
Activity
Filter activity
added bugfix label
requested review from @kohl
assigned to @he66coqe
- Resolved by Nils Kohl
added 1 commit
- cec46554 - add abstract __eq__ to FunctionSpace and remove type ignore comments; implement __eq__ for EG
enabled an automatic merge when the pipeline for cec46554 succeeds
mentioned in commit e44b552f
Please register or sign in to reply