From 6abc07e6b7d76c7ddd66af68cfa14e2dc0f913cb Mon Sep 17 00:00:00 2001 From: Frederik Hennig <frederik.hennig@fau.de> Date: Thu, 23 Jan 2025 14:44:14 +0100 Subject: [PATCH] fix bool shortcut semantics --- utilities/clang-tidy/analyze.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/utilities/clang-tidy/analyze.py b/utilities/clang-tidy/analyze.py index d3f44a687..a11fc4257 100644 --- a/utilities/clang-tidy/analyze.py +++ b/utilities/clang-tidy/analyze.py @@ -190,13 +190,14 @@ def main(): include_paths.append(tests_dir / module_name) header_filter = rf".*/src/{module_name}/.*" - success = success and run_clang_tidy( + succ = run_clang_tidy( orig_db, include_paths, header_filter, output_dir / "modules" / f"{module_name}.out", f"module {module_name}", - ) + ) + success = succ and success for app_spec in params.get("apps", []): include_paths: list[pathlib.Path] @@ -213,7 +214,7 @@ def main(): else: include_paths = [apps_dir / app_name] - success = success and run_clang_tidy( + succ = success and run_clang_tidy( orig_db, include_paths, None, @@ -221,6 +222,8 @@ def main(): f"application {app_name}" ) + success = succ and success + finally: # Restore the backup shutil.move(str(database_backup), str(database_fp)) -- GitLab